`fold (xor (shl 1, x), -1) -> (rotl ~1, x)` misoptimization in zksolc
Summary
fold (xor (shl 1, x), -1) -> (rotl ~1, x) misoptimization in zksolc
Original description
The description as published by the source.
zksolc is a Solidity compiler for ZKsync. All LLVM versions since 2015 fold (xor (shl 1, x), -1) to (rotl ~1, x) if run with optimizations enabled. Here ~1 is generated as an unsigned 64 bits number (2^64-1). This number is zero-extended to 256 bits on EraVM target while it should have been sign-extended. Thus instead of producing roti 2^256 - 1, x the compiler produces rotl 2^64 - 1, x. Analysis has shown that no contracts were affected by the date of publishing this advisory. This issue has been addressed in version 1.5.3. Users are advised to upgrade and redeploy all contracts. There are no known workarounds for this vulnerability.
Source: OSV.dev (Open Source Vulnerabilities) NVD GitHub Advisory OSV
References
- advisory github.com
- advisory github.com
- advisory nvd.nist.gov
- patch github.com